fix errors thrown by errcheck linter#755
Merged
abhijeetviswa merged 6 commits intomainfrom Jun 3, 2025
Merged
Conversation
Author
|
An additional commit to enable all linters within golangci-lint needs to be made. |
348c54a to
dbd04ca
Compare
Author
|
There were staticcheck lint errors on this PR because of a broken cache. Deleted the caches from GitHub Actions and all checks passed. |
mukeshjc
previously approved these changes
Jun 3, 2025
Comment on lines
-91
to
+94
| wr.w.Write([]byte{'\n'}) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to write diagnostics: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Thought : we are simply returning unwrapped errors in other parts of this function. Maybe we don't need to wrap this one then.
Author
There was a problem hiding this comment.
Makes sense. I'll make this change.
liamcervante
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.