common: some tweaks for common helper functions#66
Merged
Conversation
This PR renames TransformUnion to InsertSetFunc, and TransformSlice to SliceFunc which should be a bit more obvious to understand. Also, the "Union" methods on the set types are ones that return a newly created set, and so we are also now more consistent with how those are named. Also adds a boolean return value to InsertSetFunc, which like the insertion methods on the set types returns true if the set was modified as a result of the operation. And adds test cases around being modified or not modified. Cleans up a few doc strings.
Contributor
Author
|
@zonewave I went back and forth on the naming of If things look good to you I think we can go ahead and cut a release with all the examples and your bug fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
TransformUniontoInsertSetFunc, andTransformSlicetoSliceFuncwhich should be a bit more obvious to understand. Also, the"Union" methods on the set types are ones that return a newly created set,
and so we are also now more consistent with how those are named.
Also adds a boolean return value to
InsertSetFunc, which like the insertionmethods on the set types returns true if the set was modified as a result
of the operation. And adds test cases around being modified or not modified.
Cleans up a few doc strings.