fix(treeset): fix RemoveFunc not remove all matched node (#63)#64
Merged
shoenig merged 2 commits intohashicorp:mainfrom May 13, 2023
Merged
fix(treeset): fix RemoveFunc not remove all matched node (#63)#64shoenig merged 2 commits intohashicorp:mainfrom
shoenig merged 2 commits intohashicorp:mainfrom
Conversation
17b8c30 to
22daadf
Compare
1. add a filterSlice method that returns the elements of s that satisfy the predicate as a slice, in order. 2. first find remove ids by filterSlice, secondly to remove by removeSlice
shoenig
approved these changes
May 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
then I find other bug:
infix can't stop when return in left node, and can to visist other node;
for example, I write a test, it can't stop in 8 .so I fix it.