treeset: avoid using goroutine / channel / context for iteration#60
Merged
treeset: avoid using goroutine / channel / context for iteration#60
Conversation
This PR swaps implementations of TreeSet.iterate to not require a background goroutine, channel, and context. Instead we use an explicit stack and a generator function to "pull" values one at time. Unlike with the goroutine, the stack object is garbage collected automatically if we do not traverse the entire tree. Inspiriation is from golang/go#56413
609db6a to
71a4421
Compare
Contributor
Author
|
@zonewave for some reason I can't add you as a reviewer ... but if you don't mind taking a look that would be helpful 🙂 |
zonewave
approved these changes
May 7, 2023
Contributor
zonewave
left a comment
There was a problem hiding this comment.
It's great, and I think we can look into refactor the iterate, infix, forEach method that are repeated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps implementations of
TreeSet.iterateto not require a background goroutine, channel, and context. Instead we use an explicit stack and a generator function to "pull" values one at time. Unlike with the goroutine, the stack object is garbage collected automatically if we do not traverse the entire tree.Inspiriation is from golang/go#56413