Skip to content

fix(treeset,iter): use context to control iterate(#52)#53

Merged
shoenig merged 1 commit intohashicorp:mainfrom
zonewave:feat_iter
May 1, 2023
Merged

fix(treeset,iter): use context to control iterate(#52)#53
shoenig merged 1 commit intohashicorp:mainfrom
zonewave:feat_iter

Conversation

@zonewave
Copy link
Copy Markdown
Contributor

@zonewave zonewave commented Apr 30, 2023

  1. use goleak
  2. treeset, infix: add bool return param, to control the traversal of the tree
  3. iterate: add context

Closes #52

1. use goleak
2. infix: add bool to return param of visit
3, iterate: add context to control
@shoenig shoenig added the bug Something isn't working label May 1, 2023
Copy link
Copy Markdown
Contributor

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks again @zonewave!

@shoenig shoenig merged commit 76643d5 into hashicorp:main May 1, 2023
@zonewave zonewave deleted the feat_iter branch May 10, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iterator method of treeSet has goroutine leaks

2 participants