sets: support json marshal/unmarshal#39
Merged
shoenig merged 1 commit intohashicorp:mainfrom Apr 24, 2023
Merged
Conversation
|
|
2fceb2c to
b840e78
Compare
shoenig
approved these changes
Apr 24, 2023
Contributor
shoenig
left a comment
There was a problem hiding this comment.
Thanks @zonewave, this looks great! The one thing I'd like to change in the future is to replace the Slice() call with iteration - but let's wait for golang/go#56413 (coming in Go 1.21?) so we can avoid creating the intermediate copy without dealing with implementation details for each type of Set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use serializable as a universal serialization interface。
set,treeSet,hashSet can use marshalJson/unmarshalJson to implement MarshalJSON/UnmarshalJSON
Closes #22