This repository was archived by the owner on Jan 18, 2026. It is now read-only.
Merged
Conversation
Contributor
Author
|
@EduardoLaranjo if you want, cherry pick my commit into your PR and merge yours. |
|
hi @slashformotion It's fine by me, feel free to merge your PR. Thanks for the closing. Much appreciated 👍 |
nrwiersma
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This pr is a continuation on the work of @EduardoLaranjo in the pr #524 . I added the flag
-enumsin the command line generator to be able to use the enum generation feature withoutFixes #428
How did I test it?
This PR contains the same tests as the original one.
I saw the comment regarding the pluralisation of the "Cards" example. In my opinion the go type should be the same as in the avsc file. Hence, the name should be "Cards" because it is that way in the golden avsc file