feat: allow CATALOG in CREATE SCHEMA and DROP SCHEMA#4277
Merged
Conversation
katzyn
reviewed
Sep 6, 2025
Contributor
Author
|
Thank you much for feedback, I will work on this. |
- do not document the optional `catalogName` because actual support is limited
- do not carry the `catalogName` along
- add tests for invalid `catalog` names
- verify catalog name and encapsulate the logic
- do not carry the catalog name along
katzyn
reviewed
Sep 6, 2025
- minor style recommendations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE SCHEMAdoes not take the catalog name #4276