Fixes #2789. StatusItem should have a disabled attribute if it can't execute.#2790
Conversation
|
Why is this targetting v1? We agreed we will not add new capabilities to v1, but only v2. |
@tig I consider this a compatible change for v1 with no breaking change and I'll also submit a PR targeting to the v2 as well. The first release for v2 will take still a long time and we need to keep v1 pleasant as possible. I really hope you understand my observation. |
But we agreed we were not adding anything new to v1. Every bit of focus we put into v1 delays v2. I think we're pretty close to getting v2 done. We just need to focus on it! |
@tig we agree not adding new features but not nothing about improving the existing one. I'm focused on v2 but actually I felling some like blocked without know where to go for now. What I did on |
The Project has tons of things that need working on. Terminal.Gui V2 Beta (view)
I do not see where a real customer has asked for this functionality. Did I miss that? |
I'm a contributor. Doesn't I haven't that right as well, for god sake. No more comments. Finished. |
tig
left a comment
There was a problem hiding this comment.
Please also submit a v2 PR for this. Thanks.
Rest assured. All the PR's you ask or asked to submit to v2 I will do it. Don't forget to merge this one, please :-) |

Fixes #2789 - Adding
CanExecuteproperty allow leveraging the power of conditional executions.Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)