Skip to content

Fixes 2780. Moving a Window that is Application.Top shouldn't be allowed.#2781

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_window-as-application-top-fix_2780
Aug 7, 2023
Merged

Fixes 2780. Moving a Window that is Application.Top shouldn't be allowed.#2781
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_window-as-application-top-fix_2780

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jul 31, 2023

Fixes #2780 - Include a terse summary of the change or which issue is fixed.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 31, 2023 23:15
Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please do a v2 version of this PR?

@tig tig merged commit 6590c58 into gui-cs:develop Aug 7, 2023
@BDisp BDisp deleted the v1_window-as-application-top-fix_2780 branch August 7, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving a Window that is Application.Top shouldn't be allowed.

2 participants