Skip to content

Fixes #2776. Pressing Alt key on a Window with only a MenuBar throws System.InvalidOperationException.#2777

Merged
tig merged 9 commits intogui-cs:developfrom
BDisp:v1_alt-key-on-window-with-menubar-fix_2776
Aug 11, 2023
Merged

Fixes #2776. Pressing Alt key on a Window with only a MenuBar throws System.InvalidOperationException.#2777
tig merged 9 commits intogui-cs:developfrom
BDisp:v1_alt-key-on-window-with-menubar-fix_2776

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jul 29, 2023

Fixes #2776 - ContentView must set the CanFocus equal as Window.CanFocus.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 29, 2023 20:39
Comment thread Terminal.Gui/Core/Window.cs
@BDisp BDisp requested a review from tig August 11, 2023 19:06
@tig tig merged commit bdf9ec1 into gui-cs:develop Aug 11, 2023
@BDisp BDisp deleted the v1_alt-key-on-window-with-menubar-fix_2776 branch August 11, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pressing Alt key on a Window with only a MenuBar throws System.InvalidOperationException.

2 participants