grpc_retry backoff overflow#747
Merged
johanbrandhorst merged 4 commits intogrpc-ecosystem:mainfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
not sure what im doing wrong :( |
Collaborator
This isn't your fault, our CI has been broken like this for a while 💀 |
johanbrandhorst
approved these changes
Feb 11, 2025
Collaborator
johanbrandhorst
left a comment
There was a problem hiding this comment.
Nice, I expect it was weird to have this actually overflow 😂. I don't think most users actually hit 37 exponentially increasing retries 😱.
Contributor
Author
|
Yea I also dont expect it to really ever happen again. But now it did and we noticed we got OOM so I had to look into it And then us adding a maxBound of 10 sec made it a little more realistic to reach that high of course |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
using math.Exp2 does add a bit of overhead but not a lot.
Verification
Added unit tests