v1: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces#426
Merged
johanbrandhorst merged 1 commit intogrpc-ecosystem:masterfrom Jun 18, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 73.21% 73.21%
=======================================
Files 42 42
Lines 1370 1370
=======================================
Hits 1003 1003
Misses 306 306
Partials 61 61
Continue to review full report at Codecov.
|
|
details go-kit/kit#1055 and prometheus/common#255 |
16 tasks
Contributor
Author
johanbrandhorst
approved these changes
Jun 16, 2021
Collaborator
johanbrandhorst
left a comment
There was a problem hiding this comment.
LGTM with a small nit
Contributor
Author
|
done |
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/go-kit/kit split out just the logging interfaces to github.com/go-kit/log to allow downstreams to avoid inheriting large numbers of additional dependencies (made visible and impacting to go modules in v0.10.0 of github.com/go-kit/kit). xref prometheus/common#255
This switches to the slimmed down logging interface module to avoid a bump to go-kit/kit v0.10.0 picking up a ton of new dependencies
v2 version in #426
cc @dims