grpc-js: Consistently reference the same options object in the channel constructor#2933
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.13.xfrom Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
this.optionsis modified on line 295, all later uses of theoptionsobject should refer tothis.optionsinstead of the localoptionsvariable. In particular, the change to theResolvingLoadBalancerconstructor call fixes #2932, because after #2854 the channel options get to the subchannel constructor through the LB policy, instead of getting merged with the channel options inchannelControlHelper.createSubchannel, and theoptionsvariable didn't contain the proxy information that the subchannel would use to connect through a proxy.