grpc-js: Rearrange some function calls to revert event order changes#2683
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.10.xfrom Mar 7, 2024
Merged
Conversation
gnossen
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2681, according to manual testing. The goal is to ensure that the
cancelledevent is emitted after thefinishevent. First, insendStatus, thenotifyOnCancelcall is moved to after actually sending the status. The most important part of that is moving it into thewantTrailersevent handler, so that it is only called after the stream is flushed, but it also needs to be in the other branches in that function. In addition, the callback in the_finalimplementations is moved to before thesendStatuscall to get the right ordering if there is a trailers-only response, which will be sent synchronously.