Expose client identity via a new abstract 'PeerUid' type#9952
Merged
ejona86 merged 4 commits intogrpc:masterfrom Mar 17, 2023
Merged
Expose client identity via a new abstract 'PeerUid' type#9952ejona86 merged 4 commits intogrpc:masterfrom
ejona86 merged 4 commits intogrpc:masterfrom
Conversation
…g the actual remote uid private to prevent misuse.
|
|
markb74
approved these changes
Mar 16, 2023
ejona86
reviewed
Mar 16, 2023
| * one). If you want the uid to pass to some other Android API, consider one of the static wrapper | ||
| * methods of {@link PeerUids} instead (or propose a new one). | ||
| */ | ||
| public final class PeerUid { |
Member
There was a problem hiding this comment.
@markb74, should this have @ExperimentalApi? Ditto for PeerUids
Contributor
Author
There was a problem hiding this comment.
It seems reasonable to me to start with this as experimental and stabilize in the future as needed. Doesn't seem like this would block our initial intended use case as there are other such classes being used without issue for now. I've added it, but let me know if we should revert for any reason.
ejona86
approved these changes
Mar 17, 2023
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Mar 20, 2023
…c#9952) The actual remote uid was kept private to prevent misuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While keeping the actual remote uid private to prevent misuse.