api: Target schema should be case insensitive #9899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URI schema are case-insensitive. Previously the code would do case-sensitive matching. We expect NameResolverProviders to return the typical canonical scheme formatting, which is lower-case. If a NameResolverProvider returns an unexpected string (upper case, unicode, etc), then it simply won't ever match. Channel users, however, can use either casing in target strings. The code implicitly already handled relative URIs by returning null, as Map.get(null) returned null.
temawi
approved these changes
Feb 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URI schema are case-insensitive. Previously the code would do case-sensitive matching. We expect NameResolverProviders to return the typical canonical scheme formatting, which is lower-case. If a NameResolverProvider returns an unexpected string (upper case, unicode, etc), then it simply won't ever match. Channel users, however, can use either casing in target strings.
The code implicitly already handled relative URIs by returning null, as Map.get(null) returned null.