Merged
Conversation
android-interop-testing/src/main/java/io/grpc/android/integrationtest/TesterActivity.java
Outdated
Show resolved
Hide resolved
...erop-testing/src/androidTest/java/io/grpc/android/integrationtest/UdsChannelInteropTest.java
Outdated
Show resolved
Hide resolved
android-interop-testing/src/main/java/io/grpc/android/integrationtest/TesterActivity.java
Outdated
Show resolved
Hide resolved
temawi
approved these changes
Feb 27, 2023
Contributor
temawi
left a comment
There was a problem hiding this comment.
Looks good, just left a couple nits about comments.
Sorry for the delay in the review!
Allows using Android's LocalSocket via a Socket adapter. Such an adapter isn't generally 100% safe, since some methods may not have any effect, but we know what methods are called by gRPC's okhttp transport and can update the adapter or the transport as appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using Android's LocalSocket via a Socket adapter. Such an adapter
isn't generally 100% safe, since some methods may not have any effect,
but we know what methods are called by gRPC's okhttp transport and can
update the adapter or the transport as appropriate.
This code is actually dates back to March and has already been used by an app for a while. This is merely the open sourcing of the code that I'd promised @kenk42292. The reflection in UDSChannelBuilder is new (previously it referenced OkHttpChannelBuilder directly) and I added a few comments. I'm disappointed we need to use Netty in the interop test, but TLS isn't really an option because Conscrypt is incompatible with non-platform Socket implementations.
@dapengzhang0, we may want to discuss if someone else should review.