okhttp:Use a locally specified value instead of Segment.SIZE in okhttp#11899
Merged
larry-safran merged 2 commits intogrpc:masterfrom Feb 14, 2025
Merged
okhttp:Use a locally specified value instead of Segment.SIZE in okhttp#11899larry-safran merged 2 commits intogrpc:masterfrom
larry-safran merged 2 commits intogrpc:masterfrom
Conversation
ejona86
reviewed
Feb 14, 2025
Member
ejona86
left a comment
There was a problem hiding this comment.
It seems that warning is there for a reason. Seems we should just make our own copy of the variable. The most we should use the variable is have a test (since we control the okio version for tests) that verifies Segment.SIZE == SEGMENT_SIZE_COPY.
… just have a test check that they are equal.
ejona86
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.