xds:Cleanup to reduce test flakiness#11895
Merged
larry-safran merged 2 commits intogrpc:masterfrom Feb 14, 2025
Merged
Conversation
…the final result will be sent since depending on timing there may be configs sent for clusters being removed with their entries as errors.
ejona86
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a possibility that when clusters are removed from a configuration, they can have their XdsClient subscriptions notified about being absent (since CDS is state of the world) which generates a callback to doesNotExist. If this happens before the CdsWatcher object is cancelled, then a new XdsConfig is sent which has those clusters marked as being in error (Status rather than value). The tests need to just ignore those updates.