Skip to content

rls: Add gauge metric recording#11175

Merged
temawi merged 4 commits into
grpc:masterfrom
temawi:rls-metrics-gauges
May 8, 2024
Merged

rls: Add gauge metric recording#11175
temawi merged 4 commits into
grpc:masterfrom
temawi:rls-metrics-gauges

Conversation

@temawi

@temawi temawi commented May 8, 2024

Copy link
Copy Markdown
Contributor

Adds these gauges:

  • grpc.lb.rls.cache_entries
  • grpc.lb.rls.cache_size

Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
@temawi temawi requested a review from ejona86 May 8, 2024 18:48

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing cache_size part of the test is the main thing to fix.

Comment thread rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java Outdated
Comment thread rls/src/test/java/io/grpc/rls/CachingRlsLbClientTest.java Outdated
Comment thread rls/src/test/java/io/grpc/rls/RlsLoadBalancerTest.java Outdated
@temawi temawi merged commit 511b9c3 into grpc:master May 8, 2024
@temawi temawi deleted the rls-metrics-gauges branch May 8, 2024 22:15
@DNVindhya DNVindhya added the TODO:backport PR needs to be backported. Removed after backport complete label May 8, 2024
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request May 9, 2024
Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
ejona86 pushed a commit that referenced this pull request May 9, 2024
Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label May 9, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants