Helper class to allow in process servers to use peer uids in test#11014
Merged
Conversation
Contributor
Author
|
See cl/613744041 |
Member
|
Can you update this to the latest piper revision ? Also please move the PeerUidTestHelper from src/main/ to src/testFixtures/. PeerUidTestHelperTest should stay in src/test/ |
Contributor
Author
|
updated |
Member
|
Can you make sure the whitespace and formatting complies with |
jdcormie
reviewed
Mar 20, 2024
jdcormie
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use in process servers for testing which currently does not allow the use peer uids due to InProcessBuilder not setting the correct values. Adding a test only interceptor so that we can use peer uids in in process servers.