Remove ThreadlessExecutor from BlockingServerStream#10496
Merged
larry-safran merged 2 commits intogrpc:masterfrom Aug 18, 2023
Merged
Remove ThreadlessExecutor from BlockingServerStream#10496larry-safran merged 2 commits intogrpc:masterfrom
larry-safran merged 2 commits intogrpc:masterfrom
Conversation
YifeiZhuang
reviewed
Aug 17, 2023
| private static RuntimeException cancelThrow(ClientCall<?, ?> call, Throwable t) { | ||
| try { | ||
| call.cancel(null, t); | ||
| } catch (Throwable e) { |
Member
There was a problem hiding this comment.
Assertion can be disabled. So this change may skip logging some error messages, its safer to not change it.
Member
There was a problem hiding this comment.
The assertion is checking for checked exceptions, which should't happen. Catching Throwable was because this was written before we could write RuntimeException | Error. I'm not worried about this change.
YifeiZhuang
reviewed
Aug 17, 2023
Member
YifeiZhuang
left a comment
There was a problem hiding this comment.
Only a minor comment.
cc. @ejona86
ejona86
approved these changes
Aug 18, 2023
| private static RuntimeException cancelThrow(ClientCall<?, ?> call, Throwable t) { | ||
| try { | ||
| call.cancel(null, t); | ||
| } catch (Throwable e) { |
Member
There was a problem hiding this comment.
The assertion is checking for checked exceptions, which should't happen. Catching Throwable was because this was written before we could write RuntimeException | Error. I'm not worried about this change.
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 29, 2023
* Remove ThreadlessExecutor from BlockingServerStream fixes grpc#10490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10490