removed assert for flakey static stride scheduler with multiple threads#10437
Merged
tonyjongyoonan merged 8 commits intogrpc:masterfrom Jul 31, 2023
Merged
removed assert for flakey static stride scheduler with multiple threads#10437tonyjongyoonan merged 8 commits intogrpc:masterfrom
tonyjongyoonan merged 8 commits intogrpc:masterfrom
Conversation
fixed check issues
…ft-1 static stride scheduler algorithm/class (currently unused)
…duler-draft-1 Revert "static stride scheduler algorithm/class (currently unused)"
YifeiZhuang
approved these changes
Jul 31, 2023
ejona86
approved these changes
Jul 31, 2023
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 14, 2023
…ds (grpc#10437) on master branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #10433, the
assertstatement seems to cause a timeout in thepick()function of WRR's static stride scheduler. Theassertwas to detect unnecessary looping in the static stride scheduler. However, the assertion does not have to be true if there are multiple threads involved. Unless a better solution is suggested, removing it seems like the best option.