Have rls's LRU Cache rely on cleanup process to remove expired entries#10400
Merged
larry-safran merged 6 commits intogrpc:masterfrom Jul 21, 2023
Merged
Have rls's LRU Cache rely on cleanup process to remove expired entries#10400larry-safran merged 6 commits intogrpc:masterfrom
larry-safran merged 6 commits intogrpc:masterfrom
Conversation
ejona86
approved these changes
Jul 21, 2023
Member
ejona86
left a comment
There was a problem hiding this comment.
Did we confirm this is the difference with other implementations?
Contributor
Author
|
In Go they don't remove the cache entry when it is expired, so at least for that language we are now doing it the same way, though they go further and reuse the cache entry rather than replace it when they get a response for an existing key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/290931431