Upgrade Protobuf Java to 3.22.3 (aka 22.3)#10045
Merged
ejona86 merged 1 commit intogrpc:masterfrom Apr 17, 2023
Merged
Conversation
This was referenced Apr 13, 2023
The version used by protoc-gen-grpc-java will be upgraded separately, because of large C++ build changes necessary. But that won't impact users at all. We are upgrading to protoc 22.3; only the grpc plugin is not upgraded. Bazel is upgraded for both Java and C++.
6eb0c48 to
9f71f67
Compare
YifeiZhuang
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version used by protoc-gen-grpc-java will be upgraded separately, because of large C++ build changes necessary. But that won't impact users at all. We are upgrading to protoc 22.3; only the grpc plugin is not upgraded.
Bazel is upgraded for both Java and C++.
This is ready but I'm not sure we want it... yet. Protobuf 22 had some serious C++ changes to the build system, dependencies, and required compilers that is delaying upgrading of some parts of the ecosystem (like our compiler plugin). Thus leaving this as draft until things appear ready to proceed.C core has committed to upgrading to 22.x, grpc/grpc#32606 . Some parts may still be ongoing (grpc/grpc#32851), but such things will block their next release.
The C++ upgrade will be handled separately. It can actually be upgraded completely independently (before or after) from Java.