Add BIND_ALLOW_ACTIVITY_STARTS to BindServiceFlags.#10008
Merged
markb74 merged 1 commit intogrpc:masterfrom Apr 11, 2023
Merged
Add BIND_ALLOW_ACTIVITY_STARTS to BindServiceFlags.#10008markb74 merged 1 commit intogrpc:masterfrom
markb74 merged 1 commit intogrpc:masterfrom
Conversation
This flag is added in the U SDK, which is still under development. Since it's just a numeric constant, we copy the value until it is stable and mark the API is experimental, with appropriate warnings about depending on it from production code. A follow-up change will be made after SDK finalization to point to the official constant (or otherwise update to match any SDK changes), at which point we can remove the `@ExternalApi` annotation. See b/274061424
jdcormie
approved these changes
Apr 4, 2023
markb74
approved these changes
Apr 11, 2023
| @ExperimentalApi("To be finalized after Android U SDK finalization") | ||
| public Builder setAllowActivityStarts(boolean newValue) { | ||
| // https://developer.android.com/reference/android/content/Context#BIND_ALLOW_ACTIVITY_STARTS | ||
| return setFlag(0x200, newValue); |
Contributor
There was a problem hiding this comment.
nit: Define a package visible constant for this? (Since it's used in the test as well).
Contributor
Author
There was a problem hiding this comment.
I was leaning against this because when the TODO is resolved, we would directly use the SDK constant everywhere, rather than just updating the package-visible constant. So this felt closer to the final version.
ejona86
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is added in the U SDK, which is still under development. Since it's just a numeric constant, we copy the value until it is stable and mark the API is experimental, with appropriate warnings about depending on it from production code.
A follow-up change will be made after SDK finalization to point to the official constant (or otherwise update to match any SDK changes), at which point we can remove the
@ExternalApiannotation.See b/274061424