[Python] Add typing_extensions dep to aio Bazel target#42001
Closed
ssam18 wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Could someone with triage access add the 'release notes: yes' label? The label validator is blocking the CI checks. |
Member
|
/gemini review |
Member
|
@ssam18 The CI is failing, please check. I think we need to update code at some more places. https://source.cloud.google.com/results/invocations/28b219dd-4a1b-4223-a21e-9c0d59933882 |
cc84297 to
9d5d680
Compare
The aio py_library target was missing @typing_extensions in its deps, causing a ModuleNotFoundError when importing grpc.aio in Bazel builds. Fixes grpc#41998
The init_test and outside_init_test files import typing_extensions but the BUILD target didn't declare it as a dep, causing the Bazel Python tests to fail in hermetic environments.
Master renamed the typing_extensions repo to grpc_typing_extensions in PR grpc#41713 to fix bzlmod naming consistency. Update the aio and tests_aio/unit deps to use the new label.
9d5d680 to
7cac07e
Compare
asheshvidyut
approved these changes
May 1, 2026
asheshvidyut
left a comment
Member
There was a problem hiding this comment.
LGTM.
Thanks for your contribution.
sreenithi
approved these changes
May 4, 2026
asheshvidyut
pushed a commit
to a-detiste/grpc
that referenced
this pull request
Jun 10, 2026
The `aio` py_library target in `src/python/grpcio/grpc/BUILD.bazel` was missing `@typing_extensions` in its deps. This causes a `ModuleNotFoundError: No module named 'typing_extensions'` at import time for any Bazel build that pulls in `grpc.aio`. The `server` target already has this dep declared correctly and this just brings `aio` in line with the same pattern. Closes grpc#42001 COPYBARA_INTEGRATE_REVIEW=grpc#42001 from ssam18:fix-aio-typing-extensions-dep 7cac07e PiperOrigin-RevId: 909856306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aiopy_library target insrc/python/grpcio/grpc/BUILD.bazelwas missing@typing_extensionsin its deps. This causes aModuleNotFoundError: No module named 'typing_extensions'at import time for any Bazel build that pulls ingrpc.aio.The
servertarget already has this dep declared correctly and this just bringsaioin line with the same pattern.