[Python] Trim Python2 backward compatiblity syntax - removed (object) inheritance#41708
Closed
a-detiste wants to merge 8 commits into
Closed
[Python] Trim Python2 backward compatiblity syntax - removed (object) inheritance#41708a-detiste wants to merge 8 commits into
a-detiste wants to merge 8 commits into
Conversation
"(object)" was there in Python 2 to difenretiate the "old" from the "new" classes. We only have "new" classes in Python 3.
Automated fix for refs/heads/master
Automated fix for refs/heads/master
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring that removes Python 2 backward compatibility syntax, specifically the explicit inheritance from object in class definitions. The changes are applied consistently across the codebase, including handwritten Python files and the C++ code responsible for generating Python gRPC stubs. This modernization is appropriate for a Python 3 codebase. The changes are correct and I have no issues to report.
sreenithi
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
We don't own the files in the third_party directory, so we shouldn't be changing it.
sreenithi
approved these changes
Mar 4, 2026
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
… inheritance (grpc#41708) "(object)" was there in Python 2 to diffenretiate the "old" from the "new" classes. We only have "new" classes in Python 3. Closes grpc#41708 PiperOrigin-RevId: 882394070
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Mar 26, 2026
… inheritance (grpc#41708) "(object)" was there in Python 2 to diffenretiate the "old" from the "new" classes. We only have "new" classes in Python 3. Closes grpc#41708 PiperOrigin-RevId: 882394070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"(object)" was there in Python 2 to diffenretiate the "old" from the "new" classes.
We only have "new" classes in Python 3.