[EventEngine] Remove an incorrect std::move in DNSServiceResolver constructor#41502
Closed
murgatroid99 wants to merge 1 commit intogrpc:masterfrom
Closed
[EventEngine] Remove an incorrect std::move in DNSServiceResolver constructor#41502murgatroid99 wants to merge 1 commit intogrpc:masterfrom
murgatroid99 wants to merge 1 commit intogrpc:masterfrom
Conversation
markdroth
approved these changes
Jan 29, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
COPYBARA_INTEGRATE_REVIEW=#41502 from murgatroid99:dns_service_resolver_move_fix b4bdd77 FUTURE_COPYBARA_INTEGRATE_REVIEW=#41502 from murgatroid99:dns_service_resolver_move_fix b4bdd77 ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/861392244](http://cl/861392244) [cl/864955066](http://cl/864955066) [cl/864932736](http://cl/864932736) [cl/864928093](http://cl/864928093) [cl/864912126](http://cl/864912126) [cl/864910687](http://cl/864910687) PiperOrigin-RevId: 861392244
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #40141. The
std::movecall there is incorrect, because theengine_field can be used later inLookupSRVandLookupTXT.