[PHP] Fix runtime error with PHp8.5 alpha because zend_exception_get_defaul…#40337
Closed
HeenaBansal20 wants to merge 1 commit intogrpc:masterfrom
Closed
[PHP] Fix runtime error with PHp8.5 alpha because zend_exception_get_defaul…#40337HeenaBansal20 wants to merge 1 commit intogrpc:masterfrom
HeenaBansal20 wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
Contributor
Author
|
Just saw there is an issue opened already for it . This fixes this issue |
|
Thank you, it fixes build, tested for Alpinelinux #40242 related commit php/php-src@a812a74 |
andypost
reviewed
Sep 29, 2025
fd59e36 to
fc664f2
Compare
fc664f2 to
4134a5a
Compare
|
Hi @andypost Is this PR good for merging? I see that the Thanks! cc: @HeenaBansal20 |
|
Thank you, yes looks ready to go |
|
I bet it's a good idea to mention PHP 8.5 support in release notes as only 2 releases left til GA https://wiki.php.net/todo/php85 |
sergiodj
added a commit
to sergiodj/os
that referenced
this pull request
Nov 19, 2025
Adopt upstream patch from grpc/grpc#40337 to fix FTBFS with PHP 8.5. Signed-off-by: Sergio Durigan Junior <sergiodj@chainguard.dev>
sergiodj
added a commit
to sergiodj/os
that referenced
this pull request
Nov 20, 2025
Adopt upstream patch from grpc/grpc#40337 to fix FTBFS with PHP 8.5. Signed-off-by: Sergio Durigan Junior <sergiodj@chainguard.dev>
Closed
pawbhard
approved these changes
Jan 6, 2026
rishesh007
approved these changes
Jan 6, 2026
pawbhard
pushed a commit
to pawbhard/grpc
that referenced
this pull request
Jan 6, 2026
…defaul… (grpc#40337) …t is remvoed PHP 8.5 removed zend_exception_get_default(). See php updates https://github.com/php/php-src/blob/747ecce51f2d55a424547d6ae852e2f7f3766e41/UPGRADING.INTERNALS#L51 Closes grpc#40337 COPYBARA_INTEGRATE_REVIEW=grpc#40337 from HeenaBansal20:master 4134a5a PiperOrigin-RevId: 852624644
pawbhard
added a commit
that referenced
this pull request
Jan 7, 2026
…zend_exception_get_… (#41354) ### Back port of PR : #40337 PHP 8.5 removed zend_exception_get_default(). See php updates https://github.com/php/php-src/blob/747ecce51f2d55a424547d6ae852e2f7f3766e41/UPGRADING.INTERNALS#L51 Closes #40337 COPYBARA_INTEGRATE_REVIEW=#40337 from HeenaBansal20:master 4134a5a PiperOrigin-RevId: 852624644 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: Heena Bansal <heena.bansal20@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t is remvoed
PHP 8.5 removed zend_exception_get_default().
See php updates
https://github.com/php/php-src/blob/747ecce51f2d55a424547d6ae852e2f7f3766e41/UPGRADING.INTERNALS#L51