[csharp tools] Option to append Async to server side method names #39010#39797
Closed
ganesh-tn wants to merge 12 commits intogrpc:masterfrom
Closed
Conversation
|
|
Member
Author
|
The default setting is enabled (true). To disable this behavior, please specify the option |
apolcyn
reviewed
Jun 17, 2025
Contributor
apolcyn
left a comment
There was a problem hiding this comment.
Thanks @ganesh-tn
A couple first comments:
Especially since this is a new feature, can we default this off?
Can we add test coverage, either in the form of an example (e..g under the examples directory), or as a unit test? (e.g. under Grpc.Tools.Tests directory)
- The default option is set to false. - An example file has been attached for reference.
apolcyn
reviewed
Jun 25, 2025
Contributor
apolcyn
left a comment
There was a problem hiding this comment.
looks like a good start, some comments
The example files have been updated and corrected.
apolcyn
reviewed
Aug 1, 2025
Member
|
Are the changes in this PR already covered by the tests present in the repo or we could add some more tests to validate the logic added in this PR? cc @ganesh-tn |
…to-server-side-method-names
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
…c#39010 (grpc#39797) Issue 39010 - Option to append Async to server side method names Closes grpc#39797 PiperOrigin-RevId: 871693172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 39010 - Option to append Async to server side method names