Closed
Conversation
asheshvidyut
commented
Jun 6, 2025
| return grpc_message; | ||
| // Just to check if CI passes | ||
| return std::move(grpc_message); |
Member
Author
There was a problem hiding this comment.
This is added to make the CI pass. Will revert this after CI passes.
sreenithi
approved these changes
Jun 6, 2025
Contributor
sreenithi
left a comment
There was a problem hiding this comment.
LGTM.
A little unrelated, but while reviewing, I found that we have this black.toml file where we have missed updating the supported Python versions so far. We can either update it in this PR itself as part of fixing black or have a separate PR later to do it.
e12937e to
a037b0d
Compare
Member
Author
Thanks. Will create another PR for that. |
b2577e0 to
de097d3
Compare
de097d3 to
c92084b
Compare
c92084b to
8c03b09
Compare
sergiitk
approved these changes
Jun 10, 2025
Member
sergiitk
left a comment
There was a problem hiding this comment.
LGTM - a few things can be fixed in a separate PR.
| default_initializer: str = ( # If non-empty, this will be used as the default initialization of this field | ||
| default_initializer: ( | ||
| str | ||
| ) = ( # If non-empty, this will be used as the default initialization of this field |
Member
There was a problem hiding this comment.
We should probably just move these comments up one level. But in a separate PR.
Comment on lines
+17
to
+18
| :path: /foo/bar | ||
| content-type: application/grpc |
Member
There was a problem hiding this comment.
I'm pretty sure the indent in front of headers is on purpose - this indicates <code> block.
anniefrchz
pushed a commit
to anniefrchz/grpc
that referenced
this pull request
Jun 25, 2025
### Description * Upgrade Black to use the latest version. [Pypi-Black (25.1.0)](https://pypi.org/project/black/) * Run `black` to reformat files to make the sanity tests pass in CI **Note - all the file changes are by `black` command** except for the black version bump which is https://github.com/grpc/grpc/pull/39774/files#diff-0512cc461bc04ba96303b81398cc5926bd16e120cbe48decd0c44ea0a8fb76e6R36 ### Testing CI Closes grpc#39774 PiperOrigin-RevId: 769640677
anniefrchz
pushed a commit
to anniefrchz/grpc
that referenced
this pull request
Jun 25, 2025
…39820) 1. Follow up on comments in grpc#39774. 2. Fix poorly formatted multiple assignment statements in src/python/grpcio/grpc/_channel.py (from the initial black migration). Closes grpc#39820 COPYBARA_INTEGRATE_REVIEW=grpc#39820 from sergiitk:python-minor-syntax-improvements 0d7ac57 PiperOrigin-RevId: 771200864
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
### Description * Upgrade Black to use the latest version. [Pypi-Black (25.1.0)](https://pypi.org/project/black/) * Run `black` to reformat files to make the sanity tests pass in CI **Note - all the file changes are by `black` command** except for the black version bump which is https://github.com/grpc/grpc/pull/39774/files#diff-0512cc461bc04ba96303b81398cc5926bd16e120cbe48decd0c44ea0a8fb76e6R36 ### Testing CI Closes grpc#39774 PiperOrigin-RevId: 769640677
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
…39820) 1. Follow up on comments in grpc#39774. 2. Fix poorly formatted multiple assignment statements in src/python/grpcio/grpc/_channel.py (from the initial black migration). Closes grpc#39820 COPYBARA_INTEGRATE_REVIEW=grpc#39820 from sergiitk:python-minor-syntax-improvements 0d7ac57 PiperOrigin-RevId: 771200864
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
blackto reformat files to make the sanity tests pass in CINote - all the file changes are by
blackcommand except for the black version bump which ishttps://github.com/grpc/grpc/pull/39774/files#diff-0512cc461bc04ba96303b81398cc5926bd16e120cbe48decd0c44ea0a8fb76e6R36
Testing
CI