Skip to content

[ruby] Drop Ruby 3.0 support#39607

Closed
chadlwilson wants to merge 19 commits intogrpc:masterfrom
chadlwilson:drop-ruby-30
Closed

[ruby] Drop Ruby 3.0 support#39607
chadlwilson wants to merge 19 commits intogrpc:masterfrom
chadlwilson:drop-ruby-30

Conversation

@chadlwilson
Copy link
Copy Markdown
Contributor

@chadlwilson chadlwilson commented May 20, 2025

Ruby 3.0 is 1-year past EOL as of 23 April 2025.

As discussed in #38515 (comment) the practice is to support older versions for 1 year after their EOL, which has now passed.

Should help speed up builds/tests and reduce gem sizes.

Ruby 3.0 is 1-year past EOL as of 23 April 2025.

Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented May 21, 2025

Thanks @chadlwilson , sent chadlwilson#18 for most of the image updates (still need to figure out arm)

@chadlwilson
Copy link
Copy Markdown
Contributor Author

Thanks @chadlwilson , sent chadlwilson#18 for most of the image updates (still need to figure out arm)

@apolcyn Merged now. Did I miss something with the arm images, or just some local cross-compile issue for you?

@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented May 21, 2025

or just some local cross-compile issue for you?

just a local issue for me

@chadlwilson
Copy link
Copy Markdown
Contributor Author

FWIW, I just noticed that this PR will race with #39567 so your call on whether it might need to land afterwards.

@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented May 22, 2025

@chadlwilson let's try chadlwilson#20 for the ruby arm image

@chadlwilson
Copy link
Copy Markdown
Contributor Author

chadlwilson commented May 23, 2025

Merged, but seems a bit hacky :(

Somewhat random guess, but are you perhaps having this issue with binfmt/qemu that affects certain container OSes, including Debian 11/Ubuntu 22? tonistiigi/binfmt#245 or tonistiigi/binfmt#240

If so, the workaround in that case seemed to be to go back to an earlier binfmt based on QEMU 7.

@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented May 23, 2025

Thanks for the pointer!

I was able to include ccache again after fiddling with that.

I am kind of liking the ruby base image. It speeds up the image build a lot vs. rvm installation, plus a bit more hermetic. If this works out I may try to update other test images to use ruby base images rather than rvm

@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented May 23, 2025

but, sent you chadlwilson#21 for that cleanup

@chadlwilson
Copy link
Copy Markdown
Contributor Author

I am kind of liking the ruby base image. It speeds up the image build a lot vs. rvm installation, plus a bit more hermetic. If this works out I may try to update other test images to use ruby base images rather than rvm

Yeah I agree this would be a lot easier/quicker than RVM installs if it otherwise serves the purpose.

@chadlwilson
Copy link
Copy Markdown
Contributor Author

Remaining failed tests seem to be unrelated?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants