[http2] Fix GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES for when BDP is disabled#39585
Closed
yashykt wants to merge 3 commits intogrpc:masterfrom
Closed
[http2] Fix GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES for when BDP is disabled#39585yashykt wants to merge 3 commits intogrpc:masterfrom
yashykt wants to merge 3 commits intogrpc:masterfrom
Conversation
tanvi-jagtap
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/401598085
GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTESis supposed to influence the initial window size for a stream. This behavior is effectively disabled if BDP is enabled (default on) and we let BDP decide the initial window size.We have a bug where if BDP is disabled, we use the value provided by
GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTESfor a very brief period of time. The first settings frame sent out has this overridden value, but we quickly change it back to the default value 65535.The above is a log from an example server. The example client has bdp disabled and stream lookahead bytes set to 1000. We first see that the server receives
INITIAL_WINDOW_SIZE = 1000but then it receives another settingINITIAL_WINDOW_SIZE = 65535shortly after.