[ruby] remove connectivity state watch thread, fix cancellations from spurious signals#39409
Closed
apolcyn wants to merge 31 commits intogrpc:masterfrom
Closed
[ruby] remove connectivity state watch thread, fix cancellations from spurious signals#39409apolcyn wants to merge 31 commits intogrpc:masterfrom
apolcyn wants to merge 31 commits intogrpc:masterfrom
Conversation
…le signals and process shutdown (grpc#36903)" This reverts commit d4b5e12.
This reverts commit eba046b.
upon timeout, probably use a per-channel conn watch cq
stanley-cheung
approved these changes
Jun 2, 2025
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #38210 (comment) for context
Now that Event Engine is enabled, we no longer need the channel polling thread, so we can remove it.
This then allows us to revert completion queue polling style back to what we had before #36916 (which can handle spurious invocations of
unblocking_func)Fork support (with event engine left enabled), is still broken on this PR as it is on master, but it will get cleaned up after #38980 (tested by manually merging and running fork tests)
While we're here:
channel_state_test.rbin favor ofconnectivity_watch_interrupted_test.rb. The former was skipped due to https://bugs.ruby-lang.org/issues/15499, the new test changes things so that we no longer hit that bug, but still exercise the no_gvl connectivity state watch machinery.