[EE] Prevent crash when address can't be resolved#37952
Closed
eugeneo wants to merge 2 commits intogrpc:masterfrom
Closed
[EE] Prevent crash when address can't be resolved#37952eugeneo wants to merge 2 commits intogrpc:masterfrom
eugeneo wants to merge 2 commits intogrpc:masterfrom
Conversation
I hit this crash working on fork support but there's a chance it happens if the file descriptor becomes bad for some other reason.
drfloob
approved these changes
Oct 21, 2024
| ~AsyncConnectionAcceptor() { | ||
| // If uds socket, unlink it so that the corresponding file is deleted. | ||
| UnlinkIfUnixDomainSocket(*socket_.sock.LocalAddress()); | ||
| auto maybe_address = socket_.sock.LocalAddress(); |
Member
There was a problem hiding this comment.
See https://abseil.io/tips/181, regarding the recommendation to avoid prefixes or suffixes on StatusOr variable names. Suggest: address.
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 6, 2024
I hit this crash working on fork support but there's a chance it happens if the file descriptor becomes bad for some other reason. Closes grpc#37952 COPYBARA_INTEGRATE_REVIEW=grpc#37952 from eugeneo:listener-no-address-crash 1e2e82f PiperOrigin-RevId: 688238823
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
I hit this crash working on fork support but there's a chance it happens if the file descriptor becomes bad for some other reason. Closes grpc#37952 COPYBARA_INTEGRATE_REVIEW=grpc#37952 from eugeneo:listener-no-address-crash 1e2e82f PiperOrigin-RevId: 688238823
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this crash working on fork support but there's a chance it happens if the file descriptor becomes bad for some other reason.