Allow configuration of the ofType introspection depth#4317
Conversation
benjie
left a comment
There was a problem hiding this comment.
Let's keep this nicely formatted :)
ofType introspection depth
|
@benjie Thanks for the suggestions. I've commited them my branch. I think for the scope of this PR that is the right move. I'd also like to take this as an opportunity to discuss formatting the introspection query. I think it would be simpler to just keep the query in one line, without indentions. This could clean up the code and save a few byte over the wire. It would of course reduce the readability. Maybe we can document the query better, so that would become less of an issue. |
|
You can always minify it by parsing it and using a GraphQL minifier. I don't think our source code should concern itself with that too much - we should make it easy to read and edit. What sort of comments do you have in mind? |
|
@Nols1000 can you run please |
|
@Nols1000 also please cover this line with a test case: You can see it here https://app.codecov.io/gh/graphql/graphql-js/pull/4317 Thanks! I decided not to submit identical MR, so now also interested in introducing this change |
JoviDeCroock
left a comment
There was a problem hiding this comment.
This looks like a good feature to have, great work, left some comments but pending those changes this should be good to go
|
@benjie At least for me it's not 100% clear how the query works. I would have expected more documentation e.g. here https://graphql.org/learn/introspection/. For me a breakdown of this introspection query would have been a great learning resource. |
…ery depth This allows for a better configuration in case the server restricts the maximum query depth.
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
|
@Nols1000 is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
## v16.14.0 (2026-05-03) #### New Feature 🚀 * [#4317](#4317) Allow configuration of the `ofType` introspection depth ([@Nols1000](https://github.com/Nols1000)) * [#4521](#4521) Add experimental support for directives on directive definitions ([@BoD](https://github.com/BoD)) #### Bug Fix 🐞 * [#4652](#4652) Fix valueFromAST variable own-property checks ([@abishekgiri](https://github.com/abishekgiri)) #### Docs 📝 * [#4706](#4706) Fix mistake in GraphQLError guidance ([@benjie](https://github.com/benjie)) #### Committers: 4 * Abishek Kumar Giri([@abishekgiri](https://github.com/abishekgiri)) * Benjie([@benjie](https://github.com/benjie)) * Benoit 'BoD' Lubek([@BoD](https://github.com/BoD)) * Nils-Börge Margotti([@Nols1000](https://github.com/Nols1000))
## v17.0.0-beta.1 (2026-05-10) #### Breaking Change 💥 * [#4729](#4729) subscribe: replace perEventExecutor with mapSourceToResponseEvent ([@yaacovCR](https://github.com/yaacovCR)) * [#4730](#4730) chore(engines): drop Node 20 support ([@yaacovCR](https://github.com/yaacovCR)) * [#4731](#4731) refactor(execution): extract buildResolveInfo helper ([@yaacovCR](https://github.com/yaacovCR)) #### New Feature 🚀 * [#4733](#4733) feat: support node v26 ([@yaacovCR](https://github.com/yaacovCR)) #### Bug Fix 🐞 * [#4725](#4725) chore: forward-port directives on directive definitions (#4521) ([@yaacovCR](https://github.com/yaacovCR)) * [#4727](#4727) chore: forward-port configuration of the `ofType` introspection depth (#4317) ([@yaacovCR](https://github.com/yaacovCR)) #### Polish 💅 * [#4728](#4728) polish: group FRAGMENT_VARIABLE_DEFINITION with executable defs ([@yaacovCR](https://github.com/yaacovCR)) #### Internal 🏠 <details> <summary> 3 PRs were merged </summary> * [#4460](#4460) internal: use node experimental-strip-types instead of ts-node ([@yaacovCR](https://github.com/yaacovCR)) * [#4732](#4732) internal: use node test instead of mocha + c8 ([@yaacovCR](https://github.com/yaacovCR)) * [#4734](#4734) internal: add comment re: rewriteRelativeImportExtensions ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Committers: 1 * Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR))
This allows for a better configuration in case the server restricts the maximum query depth.
Added by @benjie: