Skip to content

Upgrade musl and follow recommendation.#114

Merged
fniephaus merged 4 commits into
mainfrom
dev
Oct 29, 2024
Merged

Upgrade musl and follow recommendation.#114
fniephaus merged 4 commits into
mainfrom
dev

Conversation

@fniephaus

@fniephaus fniephaus commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR updates musl to 1.2.4 and zlib to 1.2.13 (see the latest recommendation). Since newer community builds of musl are no longer available on musl.cc, musl and zlib are now built from source. This takes around 30s on a free GitHub Action runner.
The PR also updates the test matrix, now that GraalVM for JDK 23 is out and macos-12 is being deprecated.

FYI @Friendseeker

@fniephaus fniephaus self-assigned this Oct 28, 2024
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 28, 2024
@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown

GraalVM Native Image Build Report

helloworld generated in 55.4s as part of the 'test-native-image-windows-msvc' job in run #421.

Environment

Java version 17.0.12+8-LTS Vendor version Oracle GraalVM 17.0.12+8.1
Graal compiler optimization level: 2, target machine: x86-64-v3, PGO: ML-inferred
C compiler cl.exe (microsoft, x64, 19.41.34123)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 1,809 59.311% 1,684 45.587% 7,635 35.793%
Reflection 618 20.262% 0 0.000% 282 1.322%
JNI 53 1.738% 30 0.812% 48 0.225%
Loaded 3,050 100.000% 3,694 100.000% 21,331 100.000%

Image Details

Category Size in % Details
Code area 2.77MB 43.926% 3,464 compilation units
Image heap 3.45MB 54.709% 48,652 objects, 108.00B for 1 resources
Other data 88.13KB 1.365%
Total 6.30MB 100.000%

Resource Usage

Garbage collection 1.68s (3.030% of total time) in 133 GCs
Peak RSS 919.92MB (5.615% of 16.00GB system memory)
CPU load 3.149 (78.729% of 4 CPU cores)

Report generated by setup-graalvm.

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown

GraalVM Native Image Build Report

helloworld generated in 1m 7s as part of the 'test-native-image-windows' job in run #421.

Environment

Java version 24+17 Vendor version GraalVM CE 24-dev+17.1
Graal compiler optimization level: 2, target machine: x86-64-v3
C compiler cl.exe (microsoft, x64, 19.41.34123)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 3,319 70.587% 3,841 43.056% 15,584 44.374%
Reflection 1,020 21.693% 7 0.078% 140 0.399%
JNI 61 1.297% 51 0.572% 52 0.148%
Loaded 4,702 100.000% 8,921 100.000% 35,120 100.000%

Image Details

Category Size in % Details
Code area 5.53MB 42.114% 8,945 compilation units
Image heap 7.25MB 55.255% 94,893 objects, 154.36KB for 55 resources
Other data 353.59KB 2.632%
Total 13.12MB 100.000%

Resource Usage

Garbage collection 2.05s (3.045% of total time) in 436 GCs
Peak RSS 918.81MB (5.608% of 16.00GB system memory)
CPU load 2.843 (71.069% of 4 CPU cores)

Report generated by setup-graalvm.

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown

GraalVM Native Image Build Report

helloworld generated in 49.2s as part of the 'test-native-image-musl' job in run #421.

Environment

Java version 24+17 Vendor version GraalVM CE 24-dev+17.1
Graal compiler optimization level: 2, target machine: x86-64-v3
C compiler x86_64-linux-musl-gcc (linux, x86_64, 11.4.0)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 3,335 69.960% 3,837 42.886% 15,570 44.027%
Reflection 1,032 21.649% 7 0.078% 140 0.396%
JNI 57 1.196% 57 0.637% 52 0.147%
Loaded 4,767 100.000% 8,947 100.000% 35,365 100.000%

Image Details

Category Size in % Details
Code area 5.34MB 40.126% 8,918 compilation units
Image heap 7.25MB 54.469% 95,019 objects, 154.36KB for 55 resources
Other data 736.68KB 5.405%
Total 13.31MB 100.000%

Resource Usage

Garbage collection 1.90s (3.852% of total time) in 483 GCs
Peak RSS 930.25MB (5.821% of 15.61GB system memory)
CPU load 3.663 (91.566% of 4 CPU cores)

Report generated by setup-graalvm.

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown

GraalVM Native Image Build Report

helloworld generated in 45.4s as part of the 'test-extensive' job in run #421.

Environment

Java version 17.0.8+9-LTS Vendor version Oracle GraalVM 17.0.8+9.1
Graal compiler optimization level: 2, target machine: x86-64-v3, PGO: ML-inferred
C compiler gcc (linux, x86_64, 11.4.0)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 1,853 59.145% 1,737 46.369% 7,712 35.613%
Reflection 638 20.364% 0 0.000% 281 1.298%
JNI 49 1.564% 32 0.854% 48 0.222%
Loaded 3,133 100.000% 3,746 100.000% 21,655 100.000%

Image Details

Category Size in % Details
Code area 2.75MB 23.176% 3,484 compilation units
Image heap 3.46MB 29.168% 48,928 objects, 108.00B for 1 resources
Debug info 5.33MB 44.899%
Other data 335.40KB 2.757%
Total 11.88MB 100.000%

Resource Usage

Garbage collection 1.51s (3.323% of total time) in 126 GCs
Peak RSS 1.14GB (7.289% of 15.61GB system memory)
CPU load 3.613 (90.317% of 4 CPU cores)

Report generated by setup-graalvm.

olpaw
olpaw reviewed Oct 28, 2024
View reviewed changes
Comment thread src/features/musl.ts
olpaw
olpaw reviewed Oct 28, 2024
View reviewed changes
Comment thread src/features/musl.ts
olpaw
olpaw reviewed Oct 28, 2024
View reviewed changes
Comment thread src/features/musl.ts
shaunsmith
shaunsmith approved these changes Oct 29, 2024
View reviewed changes

@shaunsmith shaunsmith left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fniephaus fniephaus merged commit 557ffcf into main Oct 29, 2024
@fniephaus fniephaus deleted the dev branch October 29, 2024 14:50
@borkdude borkdude mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alina-yur alina-yur alina-yur approved these changes

+2 more reviewers

@olpaw olpaw olpaw left review comments

@shaunsmith shaunsmith shaunsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fniephaus fniephaus

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fniephaus @shaunsmith @alina-yur @olpaw