Don't propagate "not exist" error if trying to erase a session matchi…#252
Merged
coreydaley merged 3 commits intogorilla:mainfrom Aug 17, 2023
mariusor:master
Merged
Don't propagate "not exist" error if trying to erase a session matchi…#252coreydaley merged 3 commits intogorilla:mainfrom mariusor:master
coreydaley merged 3 commits intogorilla:mainfrom
mariusor:master
Conversation
|
Checks out to me, I recommend this is merged in after #253 |
Contributor
Author
|
Thank you for the support @DavidLarsKetch :) Are you affiliated with the project in an official capacity? |
|
Not yet, just trying to lend a hand with review. I think @elithrar is still the only one with write permissions. |
…ng a missing file
|
This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days. |
coreydaley
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 4 4
Lines 268 268
=======================================
Hits 206 206
Misses 54 54
Partials 8 8
|
Contributor
Author
|
Whoa! Thank you @coreydaley 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Don't consider "oserror.ErrNotExist" as a failure when trying to erase a session which corresponds to a missing file.
Hello, in the current implementation, if a request contains a session token that has been stored in a file that has been deleted and we're trying to erase it using the Options.MaxAge = -1 workaround, the action still fails, because the missing file error gets propagated higher in the stack.
This small fix prevents this, and ensures that the session is regenerated.
This is a reopen of #237 which was closed by the stale bot.