Skip to content

refactor: improved artifact filters#6024

Merged
caarlos0 merged 2 commits intomainfrom
artifact-filters
Aug 28, 2025
Merged

refactor: improved artifact filters#6024
caarlos0 merged 2 commits intomainfrom
artifact-filters

Conversation

@caarlos0
Copy link
Copy Markdown
Member

Instead of repeating Or(BySomething(), BySomething()), added pluralized versions of some filters that automatically do that.

Refactored some of the usage to use these new functions as well.

@caarlos0 caarlos0 self-assigned this Aug 26, 2025
@pull-request-size pull-request-size Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 26, 2025
Instead of repeating `Or(BySomething(), BySomething())`, added
pluralized versions of some filters that automatically do that.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Aug 26, 2025

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7a729a
Status: ✅  Deploy successful!
Preview URL: https://77fb1883.goreleaser.pages.dev
Branch Preview URL: https://artifact-filters.goreleaser.pages.dev

View logs

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 98.14815% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.82%. Comparing base (e881586) to head (d7a729a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/pipe/notary/macos.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6024      +/-   ##
==========================================
- Coverage   82.84%   82.82%   -0.02%     
==========================================
  Files         167      167              
  Lines       16961    16930      -31     
==========================================
- Hits        14052    14023      -29     
+ Misses       2304     2302       -2     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caarlos0 caarlos0 merged commit 70ab655 into main Aug 28, 2025
17 checks passed
@caarlos0 caarlos0 deleted the artifact-filters branch August 28, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant