Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
| Latest commit: |
56ac92d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e6eb3e8.goreleaser.pages.dev |
| Branch Preview URL: | https://makeself-refactor-v3.goreleaser.pages.dev |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6023 +/- ##
==========================================
- Coverage 82.82% 82.71% -0.12%
==========================================
Files 167 168 +1
Lines 16930 17175 +245
==========================================
+ Hits 14023 14206 +183
- Misses 2302 2346 +44
- Partials 605 623 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds makeself support to GoReleaser, enabling creation of self-extracting archives. This builds on previous work and provides a simplified implementation for creating executable files that self-extract and can run installation scripts.
- Adds complete makeself pipe implementation with configuration, defaults, and execution logic
- Integrates makeself artifacts into existing GoReleaser pipelines (signing, checksums, uploads, etc.)
- Includes comprehensive documentation and test coverage
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| www/mkdocs.yml | Adds navigation entry for makeself documentation |
| www/docs/customization/makeself.md | Complete documentation for makeself feature configuration |
| pkg/defaults/defaults.go | Registers makeself pipe in defaulters |
| pkg/config/config.go | Defines Makeself and MakeselfFile configuration structs |
| internal/skips/skips.go | Adds makeself skip key to skips system |
| internal/pipeline/pipeline.go | Integrates makeself pipe into main pipeline |
| internal/pipe/sign/sign.go | Includes makeself artifacts in signing pipeline |
| internal/pipe/reportsizes/reportsizes.go | Includes makeself artifacts in size reporting |
| internal/pipe/release/release.go | Includes makeself artifacts in release uploads |
| internal/pipe/makeself/ | Core makeself implementation with tests and test data |
| internal/pipe/checksums/checksums.go | Includes makeself artifacts in checksum generation |
| internal/pipe/blob/upload.go | Includes makeself artifacts in blob uploads |
| internal/http/http.go | Includes makeself artifacts in HTTP uploads |
| internal/artifact/artifact.go | Defines Makeself artifact type |
| .github/workflows/build.yml | Installs makeself tool for CI testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds up on the work of @faisal-smarthub, adding makeself support to goreleaser.
I've greatly simplified the original implementation, removing many options from it as well.
It's still not quite there, though - but it already works and can be tested!
refs #5989
refs #5994
TODO