feat: homebrew casks by caarlos0 · Pull Request #5780 · goreleaser/goreleaser

caarlos0 · 2025-05-21T04:24:40Z

add a new homebrew_casks root configuration
copy the brew pipe into a new one and make the required changes so it generates casks instead of formulae
deprecate the old brews
document how to migrate - e.g. user will need to delete old formula from the /Formula folder, new default should be Cask
test zap
test completions
test manpages
document new section
deprecate old section

closes #5607
closes #5594

refs https://github.com/Homebrew/brew/blob/master/docs/Cask-Cookbook.md

- rename cask.rb to formula.rb - change type to BrewFormula instead of BrewTap

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

cloudflare-workers-and-pages · 2025-05-21T12:38:16Z

Deploying goreleaser with Cloudflare Pages

Latest commit:	`c2eb36d`
Status:	✅ Deploy successful!
Preview URL:	https://a6a332ba.goreleaser.pages.dev
Branch Preview URL:	https://newb.goreleaser.pages.dev

View logs

SMillerDev

Looking great! Thanks so much for the work, just a few nits to make it official quality.

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

codecov · 2025-05-22T13:14:07Z

Codecov Report

Attention: Patch coverage is 82.92683% with 63 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (78104b3) to head (5a72d6c).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/pipe/cask/cask.go	79.27%	46 Missing and 17 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5780      +/-   ##
==========================================
- Coverage   82.93%   82.93%   -0.01%     
==========================================
  Files         161      163       +2     
  Lines       15932    16292     +360     
==========================================
+ Hits        13214    13511     +297     
- Misses       2144     2190      +46     
- Partials      574      591      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

Adds support for generating Homebrew casks alongside deprecating the old brews pipe. Key changes include:

Introduces a new homebrew_casks configuration and corresponding template logic under internal/pipe/cask
Deprecates the old brews pipe and updates related constants and behavior
Provides golden test data for cask output and updates the main .goreleaser.yaml to use casks

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.goreleaser.yaml	Replaced `brews` section with `homebrew_casks`
internal/pipe/cask/templates/linux_packages.rb	Added Linux package blocks for casks
internal/pipe/cask/templates/macos_packages.rb	Added macOS package blocks for casks
internal/pipe/cask/templates/cask.rb	Main cask template generating full Ruby casks
internal/pipe/cask/template.go	Data struct and embedding for cask templates
internal/pipe/brew/brew.go & brew_test.go	Deprecation notices and updated constants
internal/artifact/artifact.go	Introduced `BrewCask` type alongside `BrewFormula`
internal/pipe/cask/testdata/TestFullPipe/*.golden	Golden files for cask pipeline tests

Comments suppressed due to low confidence (3)

.goreleaser.yaml:221

The YAML key homebrew_casks may not align with the Go struct field HomebrewCask (singular). Verify the mapping or rename the key to match the struct name.

homebrew_casks:

internal/pipe/cask/template.go:1

[nitpick] There are no unit tests for the new cask pipe implementation. Consider adding tests under internal/pipe/cask to validate template rendering and publishing workflows.

package cask

internal/pipe/cask/templates/linux_packages.rb:7

[nitpick] The ARM block nesting is misaligned: the if inside this branch doesn't match a corresponding do/end for an on_arm block. Consider using on_arm do ... end consistently and ensure each conditional block is properly closed.

{{- else if eq $element.Arch "arm" }}

SMillerDev

Okay, couple more notes.

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

and some other small, unrelated changes

caarlos0 · 2025-05-23T23:54:09Z

Gonna merge this so it gets in the next nightly builds!

Thanks so much for all the help and support here @SMillerDev! Really appreciate it <3
Feel free to comment if you have any other pointers 🙏

SMillerDev · 2025-05-24T06:45:36Z

Thanks for the work here! Very happy to see the situation improved for both Homebrew and Goreleaser.

juanibiapina · 2025-11-20T16:55:49Z

I really like using formulas for downloading binaries. I see it is deprecated, but do you plan to remove it? It would be slightly annoying to have to add another Github action just for this, although not a big deal I guess.

SMillerDev · 2025-11-21T09:04:23Z

What is better about formula for your usage? From the brew side there isn't anything I can think of that would work better as a formula.

juanibiapina · 2025-11-21T10:46:59Z

Not having to sign it is the advantage, but I see there's a workaround when using a cask.

caarlos0 added 4 commits May 20, 2025 23:42

refactor: preparing for new homebrew taps

b56cf6a

- rename cask.rb to formula.rb - change type to BrewFormula instead of BrewTap

feat: homebrew_casks

ed8c78a

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

wip

d09b6e6

wip

240aeb8

caarlos0 self-assigned this May 21, 2025

pull-request-size Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 21, 2025

caarlos0 added enhancement New feature or request and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2025

pull-request-size Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 21, 2025

caarlos0 mentioned this pull request May 21, 2025

feat: generate casks instead of formulae #5607

Closed

SMillerDev reviewed May 21, 2025

View reviewed changes

Comment thread internal/pipe/cask/templates/cask.rb Outdated

Comment thread internal/pipe/cask/templates/cask.rb Outdated

fix: service

53e2263

caarlos0 added 11 commits May 21, 2025 09:47

fix: caveats, postflight

cfef8ee

fix: wire new pipe

bbeae3f

feat: update depends_on and conflicts_with

6ef4c3f

feat: postflight/preflight hooks

15c3f34

feat: many improvements

bfdaefe

feat: docs, zap, uninstall, cleanups

b15d8ce

fix: rename

19df8d0

fix: indent

f0f58f7

fix: caveats

0893cdf

docs: update

ef8b942

docs: update

2fd379d

SMillerDev reviewed May 22, 2025

View reviewed changes

caarlos0 and others added 5 commits May 22, 2025 09:42

Update internal/artifact/artifact.go

73f3307

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

Apply suggestions from code review

0b1325d

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

feat: simplify things, code review

33a110a

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

fix: more cleanups

46c24f7

fix: cfg

db68095

Merge remote-tracking branch 'origin/main' into newb

6bda136

caarlos0 added 5 commits May 22, 2025 10:16

fix: remove unused templ func

492efff

fix: brew deprecation

a7e0302

chore: style

c02c774

fix: compile

06a2180

test: fix

70c97c0

caarlos0 requested a review from Copilot May 22, 2025 13:54

Copilot AI reviewed May 22, 2025

View reviewed changes

Comment thread internal/pipe/cask/templates/linux_packages.rb Outdated

SMillerDev reviewed May 22, 2025

View reviewed changes

Comment thread internal/pipe/cask/templates/cask.rb Outdated

Comment thread internal/pipe/cask/testdata/TestFullPipe/uninstall.rb.golden Outdated

Comment thread internal/pipe/cask/testdata/TestFullPipe/zap.rb.golden Outdated

caarlos0 and others added 7 commits May 22, 2025 11:56

fix: improve template

34825e7

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

fix: template

efb6dab

Merge remote-tracking branch 'origin/main' into newb

ab27131

fix: do not repeat zap/uninstall stanzas

c5ba06b

fix: rm unused

5a72d6c

docs: fixes for homebrew

97ab7be

and some other small, unrelated changes

docs: update

c2eb36d

caarlos0 merged commit c8fd3bd into main May 23, 2025
14 of 16 checks passed

caarlos0 deleted the newb branch May 23, 2025 23:54

This was referenced Jul 24, 2025

chore(super-linter): Disable VALIDATE_GO_RELEASER until we migrate to Brew casks warrensbox/terraform-switcher#606

Closed

Goreleaser/Homebrew: migrate from Formula to Cask warrensbox/terraform-switcher#607

Closed

Uh oh!

Conversation

caarlos0 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying goreleaser with Cloudflare Pages

Uh oh!

SMillerDev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

SMillerDev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caarlos0 commented May 23, 2025

Uh oh!

Uh oh!

SMillerDev commented May 24, 2025

Uh oh!

juanibiapina commented Nov 20, 2025

Uh oh!

SMillerDev commented Nov 21, 2025

Uh oh!

juanibiapina commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

caarlos0 commented May 21, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 21, 2025 •

edited

Loading

codecov Bot commented May 22, 2025 •

edited

Loading

juanibiapina commented Nov 21, 2025 •

edited

Loading