Skip to content

feat(notarize): allows setting signing entitlements#5465

Merged
caarlos0 merged 1 commit intomainfrom
sign-entitlements
Jan 17, 2025
Merged

feat(notarize): allows setting signing entitlements#5465
caarlos0 merged 1 commit intomainfrom
sign-entitlements

Conversation

@caarlos0
Copy link
Copy Markdown
Member

closes #5464

@caarlos0 caarlos0 self-assigned this Jan 17, 2025
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 17, 2025

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53e3556
Status: ✅  Deploy successful!
Preview URL: https://6f39e620.goreleaser.pages.dev
Branch Preview URL: https://sign-entitlements.goreleaser.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (f60ae9e) to head (53e3556).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pipe/notary/macos.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5465      +/-   ##
==========================================
- Coverage   82.87%   82.86%   -0.01%     
==========================================
  Files         157      157              
  Lines       15366    15368       +2     
==========================================
+ Hits        12734    12735       +1     
- Misses       2080     2081       +1     
  Partials      552      552              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 7f03cb8 into main Jan 17, 2025
@caarlos0 caarlos0 deleted the sign-entitlements branch January 17, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support entitlements in macOS signing process

2 participants