feat(docker): suggest image if not found#5451
Merged
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying goreleaser with
|
| Latest commit: |
ec86ecd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb541861.goreleaser.pages.dev |
| Branch Preview URL: | https://docker-manifest-suggest-imag.goreleaser.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
=======================================
Coverage 82.86% 82.87%
=======================================
Files 157 157
Lines 15350 15358 +8
=======================================
+ Hits 12720 12728 +8
Misses 2079 2079
Partials 551 551 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a typo in the
docker_manifestssetup, the error ends up not being too helpful.This improves it a little by using levenshtein distances to figure out if it might have been a typo, and suggesting it.
It should not affect the behavior of how things work, besides the warning change.
Had the idea while helping @rs, so thanks for that 🙏🏻