Skip to content

feat(ko): snapshot builds#5116

Merged
caarlos0 merged 3 commits intomainfrom
ko
Sep 7, 2024
Merged

feat(ko): snapshot builds#5116
caarlos0 merged 3 commits intomainfrom
ko

Conversation

@caarlos0
Copy link
Copy Markdown
Member

@caarlos0 caarlos0 commented Sep 4, 2024

this makes ko run on snapshot builds, too.

the image will be goreleaser.ko.local:[your tags], not sure if we can change this, seems like we can't.

also fixed a small doc error around it, as well as added a new test to cover this.

closes #4683

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Sep 4, 2024

Deploying goreleaser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 37dee43
Status: ✅  Deploy successful!
Preview URL: https://44bfd74e.goreleaser.pages.dev
Branch Preview URL: https://ko.goreleaser.pages.dev

View logs

@caarlos0 caarlos0 requested a review from Dentrax September 4, 2024 01:02
@caarlos0 caarlos0 added the enhancement New feature or request label Sep 4, 2024
@caarlos0
Copy link
Copy Markdown
Member Author

caarlos0 commented Sep 4, 2024

@Dentrax if you can please take a look at this, thanksss <3

@caarlos0 caarlos0 mentioned this pull request Sep 4, 2024
3 tasks
@caarlos0 caarlos0 merged commit 708cd89 into main Sep 7, 2024
@caarlos0 caarlos0 deleted the ko branch September 7, 2024 14:15
@Dentrax
Copy link
Copy Markdown
Collaborator

Dentrax commented Sep 7, 2024

Thank you Carlos for such a great work here! Apologies, I couldn't get back to you fast, it seems it's merged! 🎉 I'd like to give it a try.

@caarlos0
Copy link
Copy Markdown
Member Author

caarlos0 commented Sep 7, 2024

yes, trying to clean up issues/prs a bit, feel free to test it and report any issues you may find!

thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger ko target in snapshot mode

2 participants