feat: [#823] register service providers to bootstrap/providers.go#25
Merged
feat: [#823] register service providers to bootstrap/providers.go#25
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Goravel SQLite package to support both standard and bootstrap setup patterns by introducing conditional service provider registration. The changes enable the package to detect the application environment and register the SQLite service provider in the appropriate location (either app.go or bootstrap/providers.go).
Key changes:
- Added environment-aware conditional logic using
env.IsBootstrapSetup()to support both standard and bootstrap setups - Refactored config variable from package-level to function-level scope for better encapsulation
- Updated Go version to 1.24.0 and refreshed dependencies to latest stable versions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup/setup.go | Implemented conditional service provider registration logic with modify.When() to support both standard (app.go) and bootstrap (bootstrap/providers.go) setups; refactored config variables for better maintainability |
| go.mod | Updated Go version to 1.24.0 and upgraded core dependencies including goravel/framework, testify, gorm, and various indirect dependencies |
| go.sum | Updated checksums to reflect all dependency changes in go.mod, adding new transitive dependencies and updating existing ones |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#823
This pull request updates dependencies and refactors the setup logic for the SQLite integration to support both standard and bootstrap setups in Goravel. The changes improve compatibility with newer versions and make the setup/uninstall process more flexible based on the environment.
Dependency updates:
1.24.0and refreshed many dependencies to their latest versions, includinggoravel/framework,testify,gorm, and several indirect dependencies for improved stability and compatibility.Setup logic improvements:
setup/setup.goto use conditional logic (modify.When) for installing and uninstalling the SQLite service provider, supporting both standard and bootstrap setups by detecting the environment withenv.IsBootstrapSetup().github.com/goravel/framework/support/envto facilitate environment-based logic in the setup process.databaseConnectionsConfig,databaseConfig) for better maintainability and clarity.✅ Checks