feat: add UUID and ULID type support in grammar#56
Merged
hwbrzzl merged 2 commits intogoravel:masterfrom Jul 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for UUID and ULID column types in the Grammar class and includes unit tests to verify their generated SQL types.
- Introduces
TypeUuidandTypeUlidmethods ingrammar.go. - Adds
TestTypeUuidandTestTypeUlidingrammar_test.goto cover the new types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| grammar.go | Added TypeUuid (returns "uuid") and TypeUlid (returns "char(26)") methods. |
| grammar_test.go | Added TestTypeUuid and TestTypeUlid to ensure correct SQL type mappings. |
Comments suppressed due to low confidence (1)
grammar.go:780
- [nitpick] Consider adding a doc comment above this method to explain its purpose and ensure consistency with existing method documentation.
func (r *Grammar) TypeUuid(column driver.ColumnDefinition) string {
1 task
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Related: goravel/framework#1114
This pull request introduces support for two new database column types,
uuidandulid, in theGrammarclass, along with corresponding unit tests to ensure their correctness.Added support for new column types:
grammar.go: Added methodsTypeUuidandTypeUlidto theGrammarclass to define the database column typesuuidandchar(26)respectively.Added unit tests for new column types:
grammar_test.go: Added test casesTestTypeUuidandTestTypeUlidin theGrammarSuiteto verify the correct mapping of theuuidandulidcolumn types.✅ Checks