Skip to content

feat: [#376] ctx.Request() supports get multiple files directly#973

Merged
almas-x merged 2 commits intomasterfrom
almas/#376
Mar 27, 2025
Merged

feat: [#376] ctx.Request() supports get multiple files directly#973
almas-x merged 2 commits intomasterfrom
almas/#376

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Mar 26, 2025

📑 Description

Closes goravel/goravel#376

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from a team as a code owner March 26, 2025 09:43
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (b526c53) to head (f2c158e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files         160      160           
  Lines       10718    10718           
=======================================
  Hits         7412     7412           
  Misses       2970     2970           
  Partials      336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

func (r *TestRequest) Header(key string, defaultValue ...string) string {
panic("do not need to implement it")
type TestRequest struct {
contractshttp.ContextRequest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@almas-x almas-x merged commit aec2bbb into master Mar 27, 2025
13 checks passed
@almas-x almas-x deleted the almas/#376 branch March 27, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature] ctx.Request() supports get multiple files directly

2 participants