Skip to content

feat: [#640] Optimize console ctx.Confirm method#971

Merged
almas-x merged 1 commit intomasterfrom
almas/#640
Mar 26, 2025
Merged

feat: [#640] Optimize console ctx.Confirm method#971
almas-x merged 1 commit intomasterfrom
almas/#640

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Mar 26, 2025

📑 Description

Closes goravel/goravel#640

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from a team as a code owner March 26, 2025 01:57
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.14%. Comparing base (1b9ab33) to head (eba920f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
console/cli_context.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   69.21%   69.14%   -0.07%     
==========================================
  Files         160      160              
  Lines       10736    10719      -17     
==========================================
- Hits         7431     7412      -19     
- Misses       2969     2971       +2     
  Partials      336      336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@almas-x almas-x merged commit 7801f1d into master Mar 26, 2025
11 of 13 checks passed
@almas-x almas-x deleted the almas/#640 branch March 26, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize console ctx.Confirm method

2 participants